Update fastssz #6760
Merged
Update fastssz #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Jul 29, 2020
Merged
|
Looks like this is blocked by #6761 for go builds. |
rauljordan
previously approved these changes
Jul 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #6760 +/- ##
==========================================
- Coverage 62.40% 62.37% -0.03%
==========================================
Files 408 406 -2
Lines 32543 31597 -946
==========================================
- Hits 20308 19710 -598
+ Misses 9413 9098 -315
+ Partials 2822 2789 -33 |
0xKiwi
reviewed
Aug 23, 2020
Comment on lines
+6
to
+9
| #build:remote-cache --spawn_strategy=standalone | ||
| #build:remote-cache --strategy=Javac=standalone | ||
| #build:remote-cache --strategy=Closure=standalone | ||
| #build:remote-cache --strategy=Genrule=standalone |
There was a problem hiding this comment.
Should these stay commented?
There was a problem hiding this comment.
yep! Otherwise fssz generation fails for some reason...
nisdas
reviewed
Aug 23, 2020
| if err != nil { | ||
| s := testutil.NewBeaconState() | ||
| if err := s.SetSlot(slot); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
instead of panicking here maybe we can pass in the testing.T to this method.
| return signingData(func() ([32]byte, error) { | ||
| if v, ok := object.(fssz.HashRoot); ok { | ||
| return v.HashTreeRoot() | ||
| } |
There was a problem hiding this comment.
you can remove the below 2 cases, its covered by fastssz
0xKiwi
reviewed
Aug 23, 2020
0xKiwi
reviewed
Aug 23, 2020
terencechain
previously approved these changes
Aug 23, 2020
terencechain
added a commit
that referenced
this pull request
Aug 24, 2020
This reverts commit 78a25f9.
This was referenced Aug 24, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR updates fastssz to include the generated HashTreeRoot methods. ferranbt/fastssz#8
This PR also changes all possible usages of ssz.HashTreeRoot to use the generated method.
Which issues(s) does this PR fix?
N/A
Other notes for review
This should have a non-trivial performance improvement with HTR methods, except for BeaconState which does not use the generated HTR.